samples/modules/chre: Support picolibc %p for NULL pointers #53574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 tasks
galak
reviewed
Jan 25, 2023
glibc and newlib print "(nil)" for NULL pointers while picolibc just prints "0". Allow either by replacing the exact "(nil)" match with ".*" instead Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
picolibc-percent-p
branch
from
21f29c4 to
d339cd0
Compare
stephanosio
approved these changes
Jan 26, 2023
yperess
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc and newlib print "(nil)" for NULL pointers while picolibc just prints "0". Allow either by replacing the exact "(nil)" match with ".*" instead
Note that both C and POSIX specs place no specific requirements on how pointer values are represented, so this is not a question of standards compliance.
Signed-off-by: Keith Packard [email protected]