Skip to content

Conversation

GAnthony
Copy link

@GAnthony GAnthony commented May 2, 2017

The SimpleLink SDK actually encapsulates a family of devices,
of which cc32xx is just one device. Other devices can fit
under this SDK directory structure.

This expansion will also allow the import of the WiFi
host driver and its driver porting layer in the future,
inserted at the correct levels in the SimpleLink SDK
directory heirarchy.

Follow the URL (ending in "#directory-structure") referenced in
ext/hal/ti/simplelink/README which explains the SDK structure,
and where devices fit in.

Jira: ZEP-1958

Change-Id: I16515d3e3779de0d55d3b1b8e25029609d1f66c3
Signed-off-by: Gil Pitney [email protected]


This change is Reviewable

ZEPHYRINCLUDE +=-I$(srctree)/ext/hal/ti/simplelink/source/ti/devices/cc32xx
ZEPHYRINCLUDE +=-I$(srctree)/ext/hal/ti/simplelink/source/ti/devices/cc32xx/inc
ZEPHYRINCLUDE +=-I$(srctree)/ext/hal/ti/simplelink/source/ti/devices/cc32xx/driverlib
KBUILD_CFLAGS += -DUSE_CC3200_ROM_DRV_API
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GAnthony do you means that, we are deprecate the old cc3200sdk support ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the cc3200sdk will be deprecated with the cc3200 board.
However, I just noticed something about KBUILD_CFLAGS. This patch still works with the CC3220, but to be more correct, it should be KBUILD_CFLAGS += -DUSE_CC3220_ROM_DRV_API.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GAnthony thank you

@galak galak self-assigned this May 2, 2017
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make the fixup the Kbuild.

The SimpleLink SDK actually encapsulates a family of devices,
of which cc32xx is just one device.  Other devices can fit
under this SDK directory structure.

This expansion will also allow the import of the WiFi
host driver and its driver porting layer in the future,
inserted at the correct levels in the SimpleLink SDK
directory heirarchy.

Follow the URL (ending in "#directory-structure") referenced in
ext/hal/ti/simplelink/README which explains the SDK structure,
and where devices fit in.

Jira: ZEP-1958

Change-Id: I16515d3e3779de0d55d3b1b8e25029609d1f66c3
Signed-off-by: Gil Pitney <[email protected]>
@GAnthony GAnthony force-pushed the cc3220sdk_restructure branch from 36a5782 to 8fcd9df Compare May 2, 2017 21:07
@GAnthony
Copy link
Author

GAnthony commented May 2, 2017

Fixed the Makefile to use KBUILD_CFLAGS=-DUSE_CC3220_ROM_DRV_API, tested on Zephyr samples, and re-pushed the commit.

@GAnthony
Copy link
Author

GAnthony commented May 3, 2017

Not sure why getting "Shippable" failures on Mr. Chettimada's commit messages, when my commit has no such error.
Should I close and re-submit (to master branch)?

https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/200/1/tests

@galak
Copy link
Contributor

galak commented May 3, 2017

No please leave this, I'm trying to figure out why this happened myself. Not sure where gitlint is getting run.

@GAnthony
Copy link
Author

GAnthony commented May 3, 2017

It seems the test is running over my commit, plus several others, as if the commit wasn't rebased.
But, I though I rebased before pushing.
Note I did do a forced push to update the commit (which I've done in the past with github, and seems a common method for fix branches). If there is a different preferred method for modifying the PR, please let me know.

@galak
Copy link
Contributor

galak commented May 3, 2017

Waiting for Anas to expose the shippable logs so we can get more details if we can reproduce it again.

@galak galak force-pushed the arm branch 2 times, most recently from 78c0221 to a1c74b7 Compare May 4, 2017 14:02
@galak galak merged commit 42b7e5d into zephyrproject-rtos:arm May 4, 2017
@GAnthony GAnthony deleted the cc3220sdk_restructure branch May 4, 2017 22:08
MuhammedZamroodh added a commit to Zephyr4Microchip/zephyr that referenced this pull request Aug 5, 2025
* swap: fix thread swap logic

Description:
        Adding fixes for thread swap logic
        unified main thread creation and thread swap logic

Signed-off-by: Muhammed Zamroodh <[email protected]>

* swap,arch: Fix arch specific irq lock/unlock

Description:
        * logic for arch_irq_lock/unlock/unlocked
          was incorrect, modified the APIs to produce correct behavior
        * arch_swap should release the lock after swap, missed the logic
          Added fix for that

Signed-off-by: Muhammed Zamroodh <[email protected]>

* swap,thread: Fix swap from ISR and IRQ exit

Description:
        * Fix for thread swap from ISR
        * Fix for IRQ exit

Signed-off-by: Muhammed Zamroodh <[email protected]>

---------

Signed-off-by: Muhammed Zamroodh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants