riscv: Fix passing -mabi/-march to linker #28464
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
added
area: RISCV
TOOLCHAIN_LD_FLAGS gets passed to zephyr_ld_options() that will call zephyr_check_compiler_flag(). Current zephyr_check_compiler_flag() fails on RISC-V for -mabi/-march as the compiler expects them to be set together. To make this work we quote them together so they'll get treated as a single option rather than two distinct options. Doing the same for TOOLCHAIN_C_FLAGS isn't required and actually doesn't work because target_compile_options will end up keeping the quoting. Fixes zephyrproject-rtos#28456 Signed-off-by: Kumar Gala <[email protected]>
|
@galak Thanks for this. This was actually discussed here: #26545 (comment) I actually has a cleaner fix ready, but seems I missed to create a PR with it: This avoids the need to depend on quotes which could lead to other issues at a later time. |
|
placed alternative solution here: #28500 |
|
Closing this in favor of #28500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOLCHAIN_LD_FLAGS gets passed to zephyr_ld_options() that will call
zephyr_check_compiler_flag(). Current zephyr_check_compiler_flag()
fails on RISC-V for -mabi/-march as the compiler expects them to be
set together. To make this work we quote them together so they'll
get treated as a single option rather than two distinct options.
Doing the same for TOOLCHAIN_C_FLAGS isn't required and actually
doesn't work because target_compile_options will end up keeping
the quoting.
Fixes #28456
Signed-off-by: Kumar Gala [email protected]