Skip to content

Conversation

dbkinder
Copy link
Contributor

Jira: ZEP-2055

Signed-off-by: David B. Kinder [email protected]

@nashif nashif added the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Apr 29, 2017
Jira: ZEP-2055

Signed-off-by: David B. Kinder <[email protected]>
README.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove jenkins

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra A at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darn vi, done

Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove jenkins sections, we do not use jenkins anymore, a few other comments inline

@nashif nashif added Waiting for response Waiting for author's response and removed In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on labels Apr 29, 2017
@dbkinder
Copy link
Contributor Author

I used my "ostro" method of using commit --amend and push -f to make review changes (so there's only one final commit instead of stacked commits so you can see what that would look like in the new process.

@nashif
Copy link
Member

nashif commented Apr 29, 2017

Can't see anything new yet. The method you are using is the correct method and the same way we did things in gerrit.

@dbkinder
Copy link
Contributor Author

I can see the updated README.rst (with your review changes) if I click on the "files changed" a the top

@nashif nashif added In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on and removed Waiting for response Waiting for author's response labels Apr 29, 2017
@nashif nashif merged commit e7a54dc into zephyrproject-rtos:master Apr 29, 2017
@nashif nashif removed the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Apr 29, 2017
@@ -0,0 +1,87 @@
:orphan:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this, it appears on the main repo page now.

nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
…func

[cleanup] Removed unused function zjs_strequal, which has a bug anyway
frasa pushed a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
Refers to zephyrproject-rtos#17

* Basic implementation of power mode control function in Flash driver.
* Implements Flash device state changes from active to power-down and
vice-versa
* Checks and error handling still need to be completed
frasa added a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
Feat: Flash power down

Closes zephyrproject-rtos#17

See merge request blik/embedded/zephyr!24
fkan-ec pushed a commit to fkan-ec/zephyr that referenced this pull request Jan 17, 2022
NickolasLapp pushed a commit to NickolasLapp/zephyr that referenced this pull request Oct 19, 2022
LukaszMrugala pushed a commit to LukaszMrugala/zephyr that referenced this pull request Jul 3, 2024
- Rewritten in Python as tag_manifest.py
- Delete the deprecated tag_main.sh script

Signed-off-by: Connor Graydon <[email protected]>
VitekST added a commit to nxp-upstream/zephyr that referenced this pull request Jul 17, 2025
Enable GPIO0-zephyrproject-rtos#17 to be used from non-secure domains, such as the
mimxrt798s/hifi4.

Signed-off-by: Vit Stanicek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants