hal: renesas: rz: Add DMA support for RZ/A, V, T, N series #146
Conversation
nhutnguyenkc
force-pushed
the
support_renesas_rz_dma
branch
from
5927e05 to
54051ed
Compare
KhiemNguyenT
requested review from
KhiemNguyenT,
binhnguyen2434,
duynguyenxa and
thaoluonguw
|
@khoa-nguyen-18 please take a look. |
drivers/rz/README
Outdated
|
|
||
| * Use r_transfer_api.h of rzv-fsp to support the callbackSet member of the transfer_api_t struct | ||
| Impacted files: | ||
| drivers/rz/fsp/inc/api/r_transfer_api.h | ||
|
|
||
| * Change the cast type from uint32_t to uintptr_t when assigning an address to a register in the | ||
| DMAC FSP driver of the RZ/A3UL to avoid build warnings | ||
| Impacted files: | ||
| drivers/rz/fsp/src/rza/r_dmac/r_dmac.c | ||
|
|
||
| * Disable the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration of the RZ/A3UL to avoid using | ||
| FSP MMU functions | ||
| Impacted files: | ||
| drivers/rz/fsp/src/rza/bsp/mcu/rza3ul/bsp_feature.h |
There was a problem hiding this comment.
Please separate these updates into other commits to make them easier to track
There was a problem hiding this comment.
Already, please help me check those commits. There are 4 commits for each
There was a problem hiding this comment.
On the RA side, we separate any changes that modify the original FSP source into a different commit, separate from the commit that adds support.
My suggestion is that, in addition to the 4 commits where you add support, please create other commits specifically for these change
There was a problem hiding this comment.
We have split these changes into separate commits. Please help me check again.
| #define BSP_FEATURE_BSP_SUPPORT_PLL5_CONFIG (0U) | ||
| #define BSP_FEATURE_BSP_SUPPORT_OCTAL_MEMORY (1U) | ||
| #define BSP_FEATURE_BSP_HAS_MMU_SUPPORT (1) | ||
| #define BSP_FEATURE_BSP_HAS_MMU_SUPPORT (0U) |
There was a problem hiding this comment.
Could you please explain the reason for changing this value?
There was a problem hiding this comment.
The reason is to let Zephyr handle MMU functionality. Therefore, the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration is disabled to avoid porting r_mmu module from FSP.
nhutnguyenkc
force-pushed
the
support_renesas_rz_dma
branch
from
54051ed to
bd874a3
Compare
|
@nhutnguyenkc please help to rebase this. |
Add HAL FSP DMAC_B files to support DMA for RZ/V series Signed-off-by: Hieu Nguyen <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP DMAC files to support DMA for RZ/A series Signed-off-by: Hieu Nguyen <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Disable the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration of the RZ/A3UL to let Zephyr handle MMU Signed-off-by: Hieu Nguyen <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Change the cast type from uint32_t to uintptr_t when assigning an address to a register in the DMAC FSP driver of the RZ/A3UL to avoid build warnings Signed-off-by: Hieu Nguyen <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP DMAC files to support DMA for RZ/T series Signed-off-by: Hieu Nguyen <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP DMAC files to support DMA for RZ/N series Signed-off-by: Hieu Nguyen <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
nhutnguyenkc
force-pushed
the
support_renesas_rz_dma
branch
from
bd874a3 to
612c1ba
Compare
|
Hi @KhiemNguyenT , I have already rebased to resolve conflicts. Please help me check and merge it. Thanks |
4 participants
Add HAL FSP DMA files to support DMA driver for RZ/A, V, T, N series