vega_sdk_riscv: Ignore GCC warning about potential uninitialized va #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
requested changes
Nov 2, 2022
…able When -ffreestanding is not enabled, and GCC is able to use it's knowledge of memset semantics, it sometimes gets it wrong, as in this case. I'm not quite sure what is confusing it here, but the code sure looks correct. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
ignore-maybe-uninitialized
branch
from
2187774 to
938677a
Compare
stephanosio
approved these changes
Nov 2, 2022
|
@dleach02 Could you please take a look? |
|
@dleach02 ping |
|
It would be great if we could get another +1 here. |
carlescufi
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When -ffreestanding is not enabled (as when building with picolibc), and GCC is able to use it's knowledge of memset semantics, it sometimes gets it wrong, as in this case. I'm not quite sure what is confusing it here, but the code sure looks correct.
Signed-off-by: Keith Packard [email protected]