.github: Add job names and restrict permission & credentials #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
reviewed
Aug 2, 2025
Restrict permissions explicitly Signed-off-by: Thomas Stranger <[email protected]>
Restrict default permission of the build workflows. Signed-off-by: Thomas Stranger <[email protected]>
Add names to the jobs Signed-off-by: Thomas Stranger <[email protected]>
str4t0m
force-pushed
the
actions_improve
branch
from
a63d5bf to
22a00ce
Compare
stephanosio
approved these changes
Aug 3, 2025
henrikbrixandersen
approved these changes
Aug 20, 2025
kartben
approved these changes
Oct 16, 2025
|
Thanks very much @str4t0m ! Not sure what took us so long to merge this - apologies for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed the workflows and noticed that we could set the workflow permission to contents read and avoid the default behavior of the auth token being persisted in the local git confg for subsequent steps of the git checkout action.
Additionally I added a few names to jobs that didn't have any yet.