This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Unserialize whitelist #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-mabe
reviewed
Mar 20, 2018
src/Adapter/PhpSerialize.php
Outdated
| /** | ||
| * Set options | ||
| * | ||
| * @param array|\Traversable|PhpSerializeOptions $options |
src/Adapter/PhpSerializeOptions.php
Outdated
| * Zend Framework (http://framework.zend.com/) | ||
| * | ||
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com) |
test/Adapter/PhpSerializeTest.php
Outdated
| { | ||
| $value = 'O:8:"stdClass":0:{}'; | ||
|
|
||
| $this->adapter->getOptions()->setUnserializeClassWhitelist(false); |
test/Adapter/PhpSerializeTest.php
Outdated
| { | ||
| $value = 'O:8:"stdClass":0:{}'; | ||
|
|
||
| $this->adapter->getOptions()->setUnserializeClassWhitelist([\My\Dummy::class]); |
test/Adapter/PhpSerializeTest.php
Outdated
| { | ||
| $value = 'O:8:"stdClass":0:{}'; | ||
|
|
||
| $this->adapter->getOptions()->setUnserializeClassWhitelist([\stdClass::class]); |
src/Adapter/PhpSerializeOptions.php
Outdated
| protected $unserializeClassWhitelist = true; | ||
|
|
||
| /** | ||
| * @param array|bool $unserializeClassWhitelist |
There was a problem hiding this comment.
@param string[]|bool $unserializeClassWhitelist
src/Adapter/PhpSerializeOptions.php
Outdated
| } | ||
|
|
||
| /** | ||
| * @return array|bool |
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
…list Unserialize whitelist
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
- Updates license docblocks of changed files to reflect current standards. - Use a ternary to get the return value of the `unserialize()` operation (simpler to read than if/else block). - No fluent operations in new classes. - Review all docblocks for formatting, grammar. - Use annotations to require PHP 7 for tests - split out a single test to demonstrate expected behavior in versions prior to 7.0
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
|
Thanks, @MatthiasKuehneEllerhold! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #36