Skip to content

chore: v9 QA sweep #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2024
Merged

chore: v9 QA sweep #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
751dcd6
Add dialog arrows to custom trigger examples
jzempel Sep 25, 2024
92e1e04
Enhance versions page with migration/changelog links
jzempel Sep 25, 2024
c17843e
Add v9 global alert
jzempel Sep 25, 2024
e347302
Add GlobalAlert.Close aria-label
jzempel Sep 25, 2024
635d184
Breadcrumb `Anchor` components should not be underlined
jzempel Sep 26, 2024
8b26588
Upgrade to v9.0.0-next.27
jzempel Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
272 changes: 136 additions & 136 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

42 changes: 21 additions & 21 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,27 +35,27 @@
"@zendeskgarden/container-utilities": "2.0.0",
"@zendeskgarden/css-bedrock": "9.1.1",
"@zendeskgarden/eslint-config": "43.0.0",
"@zendeskgarden/react-accordions": "9.0.0-next.26",
"@zendeskgarden/react-avatars": "9.0.0-next.26",
"@zendeskgarden/react-breadcrumbs": "9.0.0-next.26",
"@zendeskgarden/react-buttons": "9.0.0-next.26",
"@zendeskgarden/react-chrome": "9.0.0-next.26",
"@zendeskgarden/react-colorpickers": "9.0.0-next.26",
"@zendeskgarden/react-datepickers": "9.0.0-next.26",
"@zendeskgarden/react-draggable": "9.0.0-next.26",
"@zendeskgarden/react-dropdowns": "9.0.0-next.26",
"@zendeskgarden/react-forms": "9.0.0-next.26",
"@zendeskgarden/react-grid": "9.0.0-next.26",
"@zendeskgarden/react-loaders": "9.0.0-next.26",
"@zendeskgarden/react-modals": "9.0.0-next.26",
"@zendeskgarden/react-notifications": "9.0.0-next.26",
"@zendeskgarden/react-pagination": "9.0.0-next.26",
"@zendeskgarden/react-tables": "9.0.0-next.26",
"@zendeskgarden/react-tabs": "9.0.0-next.26",
"@zendeskgarden/react-tags": "9.0.0-next.26",
"@zendeskgarden/react-theming": "9.0.0-next.26",
"@zendeskgarden/react-tooltips": "9.0.0-next.26",
"@zendeskgarden/react-typography": "9.0.0-next.26",
"@zendeskgarden/react-accordions": "9.0.0-next.27",
"@zendeskgarden/react-avatars": "9.0.0-next.27",
"@zendeskgarden/react-breadcrumbs": "9.0.0-next.27",
"@zendeskgarden/react-buttons": "9.0.0-next.27",
"@zendeskgarden/react-chrome": "9.0.0-next.27",
"@zendeskgarden/react-colorpickers": "9.0.0-next.27",
"@zendeskgarden/react-datepickers": "9.0.0-next.27",
"@zendeskgarden/react-draggable": "9.0.0-next.27",
"@zendeskgarden/react-dropdowns": "9.0.0-next.27",
"@zendeskgarden/react-forms": "9.0.0-next.27",
"@zendeskgarden/react-grid": "9.0.0-next.27",
"@zendeskgarden/react-loaders": "9.0.0-next.27",
"@zendeskgarden/react-modals": "9.0.0-next.27",
"@zendeskgarden/react-notifications": "9.0.0-next.27",
"@zendeskgarden/react-pagination": "9.0.0-next.27",
"@zendeskgarden/react-tables": "9.0.0-next.27",
"@zendeskgarden/react-tabs": "9.0.0-next.27",
"@zendeskgarden/react-tags": "9.0.0-next.27",
"@zendeskgarden/react-theming": "9.0.0-next.27",
"@zendeskgarden/react-tooltips": "9.0.0-next.27",
"@zendeskgarden/react-typography": "9.0.0-next.27",
"@zendeskgarden/scripts": "2.4.0",
"@zendeskgarden/stylelint-config": "21.0.0",
"@zendeskgarden/svg-icons": "7.3.0",
Expand Down
2 changes: 1 addition & 1 deletion react-components
Open in desktop
Submodule react-components updated 53 files
+18 −0 CHANGELOG.md
+3 −38 docs/changelogs/v6.md
+2 −68 docs/changelogs/v7.md
+2 −1 docs/changelogs/v8.md
+15 −9 docs/migration.md
+39 −0 docs/migrations/v6.md
+70 −0 docs/migrations/v7.md
+1 −1 lerna.json
+141 −158 package-lock.json
+1 −1 package.json
+2 −2 packages/accordions/package.json
+1 −1 packages/avatars/demo/avatar.stories.mdx
+3 −3 packages/avatars/package.json
+1 −1 packages/breadcrumbs/demo/stories/BreadcrumbStory.tsx
+2 −2 packages/breadcrumbs/package.json
+2 −2 packages/buttons/package.json
+3 −3 packages/chrome/package.json
+6 −6 packages/colorpickers/package.json
+4 −1 packages/colorpickers/src/elements/ColorPickerDialog/index.tsx
+1 −1 packages/colorpickers/src/elements/ColorSwatch/index.tsx
+4 −1 packages/colorpickers/src/elements/ColorSwatchDialog/index.tsx
+2 −2 packages/datepickers/package.json
+3 −3 packages/draggable/package.json
+3 −3 packages/dropdowns.legacy/package.json
+7 −7 packages/dropdowns/package.json
+20 −4 packages/dropdowns/src/elements/menu/Menu.spec.tsx
+2 −0 packages/dropdowns/src/elements/menu/Menu.tsx
+2 −0 packages/dropdowns/src/types/index.ts
+2 −2 packages/forms/package.json
+4 −4 packages/grid/package.json
+2 −2 packages/loaders/package.json
+11 −0 packages/loaders/src/elements/Dots.spec.tsx
+8 −1 packages/loaders/src/elements/Inline.spec.tsx
+7 −1 packages/loaders/src/elements/Progress.spec.tsx
+16 −8 packages/loaders/src/styled/StyledInline.ts
+9 −1 packages/loaders/src/styled/StyledProgress.ts
+2 −1 packages/loaders/src/styled/StyledSVG.spec.tsx
+12 −3 packages/loaders/src/styled/StyledSVG.ts
+22 −6 packages/loaders/src/types/index.ts
+3 −3 packages/modals/package.json
+2 −1 packages/modals/src/elements/TooltipDialog/TooltipDialog.tsx
+2 −0 packages/modals/src/types/index.ts
+3 −3 packages/notifications/package.json
+2 −2 packages/pagination/package.json
+3 −3 packages/tables/package.json
+2 −2 packages/tabs/package.json
+2 −2 packages/tags/package.json
+3 −2 packages/theming/demo/stories/GetColorStory.tsx
+1 −1 packages/theming/package.json
+10 −0 packages/theming/src/utils/getColor.spec.ts
+11 −5 packages/theming/src/utils/getColor.ts
+2 −2 packages/tooltips/package.json
+2 −2 packages/typography/package.json
8 changes: 6 additions & 2 deletions src/examples/breadcrumbs/BreadcrumbsDefault.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ const Example = () => (
<Grid.Row justifyContent="center">
<Grid.Col size="auto">
<Breadcrumb>
<Anchor href="#">Flowers</Anchor>
<Anchor href="#">Roses</Anchor>
<Anchor href="#" isUnderlined={false}>
Flowers
</Anchor>
<Anchor href="#" isUnderlined={false}>
Roses
</Anchor>
<Span>Floribunda</Span>
</Breadcrumb>
</Grid.Col>
Expand Down
2 changes: 1 addition & 1 deletion src/examples/color-picker/ColorPickerDialogCustomTrigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const Example = () => {
return (
<Grid.Row>
<Grid.Col textAlign="center">
<ColorPickerDialog color={color} onChange={setColor}>
<ColorPickerDialog color={color} hasArrow onChange={setColor}>
<PaletteIconButton iconColor={iconColor} />
</ColorPickerDialog>
</Grid.Col>
Expand Down
1 change: 1 addition & 0 deletions src/examples/color-swatch/ColorSwatchCustomTrigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const Example = () => {
<ColorSwatchDialog
name="color-swatch-custom-trigger"
colors={matrix}
hasArrow
onSelect={onSelect}
selectedRowIndex={selectedRowIndex}
selectedColIndex={selectedColIndex}
Expand Down
39 changes: 37 additions & 2 deletions src/layouts/Root/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@
* found at http://www.apache.org/licenses/LICENSE-2.0.
*/

import React, { PropsWithChildren } from 'react';
import React, { PropsWithChildren, useEffect, useLayoutEffect, useState } from 'react';
import { css } from 'styled-components';
import { getColor } from '@zendeskgarden/react-theming';
import { GlobalAlert } from '@zendeskgarden/react-notifications';
import { Anchor } from '@zendeskgarden/react-buttons';
import { SkipNav } from '@zendeskgarden/react-chrome';
import Footer from './components/Footer';
import Header, { headerBoxShadow, headerHeight } from './components/Header';
Expand All @@ -18,7 +20,25 @@ interface IRootLayoutProps extends PropsWithChildren {
}

const RootLayout: React.FC<IRootLayoutProps> = ({ children, hasSkipNav = true, path }) => {
return (
const [isGlobalAlertVisible, setIsGlobalAlertVisible] = useState(true);

useLayoutEffect(() => {
// Initial global alert render
const hidden =
new Date() > new Date('2025-01-01T00:00:00Z') ||
window.localStorage.getItem('global-alert-v9') === 'hidden';

setIsGlobalAlertVisible(!hidden);
}, []);

useEffect(() => {
// Handle user dismissed global alert
if (!isGlobalAlertVisible) {
window.localStorage.setItem('global-alert-v9', 'hidden');
}
}, [isGlobalAlertVisible]);

return typeof window === 'undefined' ? null /* prevent global alert flash */ : (
Copy link
Contributor

@ze-flo ze-flo Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

<div
css={css`
display: flex;
Expand All @@ -27,6 +47,21 @@ const RootLayout: React.FC<IRootLayoutProps> = ({ children, hasSkipNav = true, p
color: ${p => getColor({ theme: p.theme, variable: 'foreground.default' })};
`}
>
{!!isGlobalAlertVisible && (
<GlobalAlert type="info">
<GlobalAlert.Content>
<GlobalAlert.Title>Garden 9 is now available.</GlobalAlert.Title>
The website has been updated to the latest major version.{' '}
<Anchor href="/components/versions">View previous versions</Anchor>
</GlobalAlert.Content>
<GlobalAlert.Close
aria-label="Close v9 alert"
onClick={() => {
setIsGlobalAlertVisible(false);
}}
/>
</GlobalAlert>
)}
{!!hasSkipNav && (
<SkipNav
targetId="main-content"
Expand Down
9 changes: 9 additions & 0 deletions src/pages/components/versions.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,18 @@ export function Head(props) {

Garden website release documentation

- Version 9
- [changelog](https://github.com/zendeskgarden/react-components/blob/main/CHANGELOG.md)
- [migration guide](https://github.com/zendeskgarden/react-components/blob/main/docs/migration.md)
- [Version 8](https://66bcf1412f3b1af56ce3fee1--zendeskgarden.netlify.app/components/)
- [changelog](https://github.com/zendeskgarden/react-components/blob/main/docs/changelogs/v8.md)
- [migration guide](https://github.com/zendeskgarden/react-components/blob/main/docs/migrations/v8.md)
- [Version 7](https://606fa12ea4f2996a9cfd97aa--zendeskgarden.netlify.app/)
- [changelog](https://github.com/zendeskgarden/react-components/blob/main/docs/changelogs/v7.md)
- [migration guide](https://github.com/zendeskgarden/react-components/blob/main/docs/migrations/v7.md)
- [Version 6](https://606f9e155f932060ab2899e8--zendeskgarden.netlify.app/)
- [changelog](https://github.com/zendeskgarden/react-components/blob/main/docs/changelogs/v6.md)
- [migration guide](https://github.com/zendeskgarden/react-components/blob/main/docs/migrations/v6.md)

import { graphql } from 'gatsby';

Expand Down