Skip to content

fix(dropdowns): Fix invalid ARIA role #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2019
Merged

fix(dropdowns): Fix invalid ARIA role #447

merged 1 commit into from
Sep 9, 2019

Conversation

@hzhu
Copy link
Contributor

@hzhu hzhu commented Sep 8, 2019

Description

There is an invalid ARIA role attribute used in the autocomplete (autocomplete.md) example page. I updated the attribute from role="image" to role="img".

Screen Shot 2019-09-07 at 11 47 36 PM

Resources:

@coveralls
Copy link

coveralls commented Sep 8, 2019

Coverage Status

Coverage remained the same at 95.82% when pulling 06dd982 on hzhu:hzhu/fix-invalid-role into 3b44001 on zendeskgarden:master.

@austingreendev austingreendev requested a review from a team September 9, 2019 14:56
austingreendev
austingreendev approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@austingreendev austingreendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the find!

@austingreendev austingreendev merged commit 4285785 into zendeskgarden:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@austingreendev austingreendev austingreendev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Docs 📝

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hzhu @coveralls @austingreendev