docs(forms): Checkbox example in forms is throwing #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clicking on the open isolated button only for the checkboxes examples throws, see gif.
Detail
Seems for whatever reason that the name
Checkboxsomehow conflicts with react-styleguidist internals, they do have aCheckboxcomponent that I tried renaming to see of that would fix the conflict but it still threw.This is a quick fix.
Checklist
design updates are Garden Designer approved (add thedesigner as a reviewer)
view component styling is based on a Garden CSScomponent
Styleguidist demo is up-to-date (yarn start)renders as expected with reversed (RTL) directionanalyzed via axe and evaluated using VoiceOverincludes new unit teststested in Chrome, Firefox, Safari, Edge, and IE11