Skip to content

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Aug 16, 2019

Description

While making some additional datepicker examples I found a few issues that I have resolved in this PR.

  • minValue and maxValue displays were off by a single day due to us comparing date values without finding a common day baseline
  • DatepickerRange usages were unable to have a start and end date that were the same value

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team August 16, 2019 22:43
@jzempel
Copy link
Member

jzempel commented Aug 22, 2019

It would be good if the range example could be tweaked under this PR. The current grid layout isn't working very nicely.

Screen Shot 2019-08-22 at 9 45 37 AM

Instead, we'd want those fields to display at a fixed 280px width directly above the corresponding begin/end months.

@austingreendev austingreendev merged commit d4357e6 into master Aug 23, 2019
@austingreendev austingreendev deleted the agreen/datepicker-bug branch August 23, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants