Update autocomplete dropdown example due to google translate issue #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiminHuang
force-pushed
the
kahuang/CADMIN-1768_DOMException_caused_by_google_translate
branch
from
09eb258 to
c844dc3
Compare
jzempel
previously requested changes
Jul 25, 2019
Member
jzempel
left a comment
jzempel
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please remove the added .DS_Store file and address the minor grammar fix.
| perform filtering is to control the `inputValue` and `onInputValueChange` props and | ||
| conditionally render `<Item>`s as necessary. | ||
|
|
||
| Due to a know issue caused by google translation extension, which replaces text node |
KaiminHuang
force-pushed
the
kahuang/CADMIN-1768_DOMException_caused_by_google_translate
branch
from
c844dc3 to
99dc741
Compare
austingreendev
approved these changes
Jul 26, 2019
Contributor
austingreendev
left a comment
austingreendev
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the contribution.
austingreendev
dismissed
jzempel’s stale review
Requested changes have been made
austingreendev
deleted the
kahuang/CADMIN-1768_DOMException_caused_by_google_translate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug is originally captured by rollbar whitin Zendesk, after upgrading dropdown component @zendeskgarden/react-dropdowns": "6.2.1" .
The problem is that Google Translate replaces text nodes with tags containing translations while React keeps references to the text nodes that are no longer in the DOM tree.
React throws in the following cases:
The easiest workaround is to wrap those text nodes with so that nodes referenced by React will stay in the DOM tree even though their contents are replaced with tags.
Detail
Checklist
designer as a reviewer)
component
yarn start)