Skip to content

feat(dropdowns): export resetIdCounter to allow SSR #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2019
Merged

feat(dropdowns): export resetIdCounter to allow SSR #387

merged 1 commit into from
Jul 12, 2019

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Jul 12, 2019 •
edited
Loading

Description

While upgrading the dependencies for the nextjs example, I found that our react-dropdowns package doesn't handle SSR correctly.

Detail

This PR upgrades the nextjs dependencies and adds a re-export to the resetIdCounter utility provided by downshift.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team July 12, 2019 19:04
@austingreendev austingreendev merged commit 72c0ef7 into master Jul 12, 2019
@austingreendev austingreendev deleted the agreen/dropdowns-ssr branch July 12, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzempel jzempel jzempel approved these changes

Assignees

No one assigned

Labels

PR: New Feature 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@austingreendev @jzempel