Skip to content

fix(dropdowns): ensure Menu closes on outside click when nested item is auto-focused #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

fix(dropdowns): ensure Menu closes on outside click when nested item is auto-focused #2035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47528eb
fix(dropdowns): ensure Menu closes on outside click when nested item …
ze-flo Jul 31, 2025
14c0765
deps: use caret version range
ze-flo Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/dropdowns/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"dependencies": {
"@floating-ui/react-dom": "^2.0.0",
"@zendeskgarden/container-combobox": "^2.0.5",
"@zendeskgarden/container-menu": "^1.0.0",
"@zendeskgarden/container-menu": "1.0.1",
Copy link
Member

@jzempel jzempel Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@zendeskgarden/container-menu": "1.0.1",
"@zendeskgarden/container-menu": "^1.0.1",

As a rule, Garden container dependencies get hat notation.

Copy link
Contributor Author

@ze-flo ze-flo Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, old habits. 🤦

"@zendeskgarden/container-utilities": "^2.0.0",
"@zendeskgarden/react-buttons": "^9.8.0",
"@zendeskgarden/react-forms": "^9.8.0",
Expand Down
Loading