fix(theming): getColor memoization peformance
#1960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
approved these changes
Oct 24, 2024
Contributor
ze-flo
left a comment
ze-flo
left a comment
There was a problem hiding this comment.
Incredible speed improvement!! 🚄 🚀 🔥🔥
Comment on lines
+31
to
+32
| const BASELINE_NOCACHE = 2780; | ||
| const BASELINE_CACHE = 2000; |
Contributor
There was a problem hiding this comment.
While not critical for this update, we could discuss ways to improve the story without having to rely on a hardcoded BASELINE.
| testGetColor(); | ||
| updateColor(initialColor); | ||
|
|
||
| const endTime = performance.now(); |
Contributor
There was a problem hiding this comment.
This is captured after React has completed all state updates. getColor, on its own, is probably much faster than that! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As advertised by the supporting stories, this PR swaps
getColorandgetColorV8JSON.stringifyargument memoization with a custom key generation backed byWeakMapcached object comparisons. The before/after results are shown below...Before (
JSON.stringify)After (custom
toKey)Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)npm start)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge