Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Oct 22, 2024

Description

Adds appendToNode to DatePicker. See accompanying storybook [patterns] demo for details.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

Coverage Status

coverage: 95.897% (+0.001%) from 95.896%
when pulling 921af54 on jzempel/datepicker-append
into bbe1263 on main.

Copy link
Contributor

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jzempel jzempel merged commit 4c887be into main Oct 22, 2024
9 checks passed
@jzempel jzempel deleted the jzempel/datepicker-append branch October 22, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants