chore: v9 QA sweep #1929
Merged
chore: v9 QA sweep #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
reviewed
Sep 25, 2024
| 'aria-label', | ||
| 'Color picker' | ||
| ); | ||
| const theme = useTheme() || DEFAULT_THEME; |
Contributor
There was a problem hiding this comment.
#1914 build the case that components should always be wrapped in ThemeProvider starting with v9. Do we still need the fallback DEFAULT_THEME?
Suggested change
| const theme = useTheme() || DEFAULT_THEME; | |
| const theme = useTheme() |
Member
Author
There was a problem hiding this comment.
My preference is to be consistent with other element-level components for now. If/when we determine to simplify, it should happen across everything.
Contributor
There was a problem hiding this comment.
Good point. 👍 We can always follow-up with a broad sweep. 🧹
ze-flo
approved these changes
Sep 25, 2024
Contributor
ze-flo
left a comment
ze-flo
left a comment
There was a problem hiding this comment.
Great job reorganizing the migration docs. 💯
| */ | ||
| referenceElement?: HTMLElement | null; | ||
| /** @ignore Modifies the placement offset from the reference element (internal only) */ | ||
| offset?: number; |
5 tasks
jzempel
added a commit
to zendeskgarden/website
that referenced
this pull request
Sep 26, 2024
- add dialog arrows to custom trigger color picker examples - add v9 `<GlobalAlert>` (expires 2025-01-01) - improve `/components/versions` page with migration/changelog doc links (depends on zendeskgarden/react-components#1929) - fix `breadcrumb` example anchors (no underline, per design) - upgrade to v9.0.0-next.27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TooltipModalinternal-onlyoffsetprop to decrease space betweenColorPickerDialog/ColorSwatchDialogand trigger (per designs)getColorstorybook demowebsitedocumentation