Skip to content

Conversation

@ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Sep 10, 2024

Description

Adds end padding to first descendant of StyledTooltipDialog if Close btn exists

Detail

With Close btn

Screenshot 2024-09-09 at 4 41 57 PM
Screenshot 2024-09-09 at 4 42 45 PM
Screenshot 2024-09-09 at 4 41 33 PM

Without Close btn

Screenshot 2024-09-09 at 4 42 23 PM

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)~~
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I'm so happy support for :has selector is as high as it is. Didn't realize its been in safari since version 15!

Co-authored-by: George Treviranus <[email protected]>
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice – CSS-only FTW 🎉. Other components (Modal, Drawer, etc) could probably remove context and benefit from this simplification.

@geotrev
Copy link
Contributor

geotrev commented Sep 10, 2024

Nice – CSS-only FTW 🎉. Other components (Modal, Drawer, etc) could probably remove context and benefit from this simplification.

It feels like maybe a few other components/packages might benefit from this (assuming the use of context isn't logic-driven) 😁

@ze-flo ze-flo requested a review from geotrev September 10, 2024 21:41
@ze-flo ze-flo merged commit 57d8e8d into main Sep 11, 2024
@ze-flo ze-flo deleted the ze-flo/tooltip-dialog-padding-fix branch September 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants