Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Sep 9, 2024

Description

Sets the background color for CodeBlock to background.recessed in order to offset from the default background in dark mode.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link

@steue steue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! ty for this JZ

@jzempel jzempel merged commit db1ca42 into main Sep 10, 2024
@jzempel jzempel deleted the jzempel/codeblock-color branch September 10, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants