fix: ensure tag script releases to the correct default branch
#1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
reviewed
Aug 22, 2024
| /** | ||
| * Push a GitHub release. | ||
| * | ||
| * @param {String} main Name for the main branch being released. |
There was a problem hiding this comment.
[nit]
Suggested change
| * @param {String} main Name for the main branch being released. | |
| * @param {String} defaultBranch Name for the default branch being released. |
There was a problem hiding this comment.
Actually maybe branch rather than defaultBranch might more suitable.
There was a problem hiding this comment.
Never mind. The version script uses main too. It might be better to keep as is for consistency.
There was a problem hiding this comment.
am i misinterpreting the argument or is main the name of the actual branch, or is it just whichever branch is provided to the script? 🤔
geotrev
approved these changes
Aug 22, 2024
ze-flo
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulls in the fix from
main(previously made onnextv9).