Skip to content

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Aug 19, 2024

Description

BREAKING CHANGE: this update paves the way for future non-modal tooltip dialog behavior.

Detail

Replaced all instances of:

  • "TooltipModal" string
  • "tooltip_modal" string
  • "TooltipModal" file/folder names

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel merged commit d454cae into next Aug 19, 2024
@jzempel jzempel deleted the jzempel/rename-tooltipdialog branch August 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants