Skip to content

chore: sync next with main #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024
Merged

chore: sync next with main #1874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
018acf0
fix(dropdowns.next): `Combobox` with `isBare` option never shows hori…
ze-flo Aug 1, 2024
b1b2cd3
chore(changelog): add v8.76.5 [skip ci]
geotrev Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/changelogs/v8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,19 @@

_Note: Gaps between patch versions are faulty, broken or test releases._

## v8.76.5 (2024-08-01)

#### :bug: Bug Fix
* `dropdowns.next`
* [#1872](https://github.com/zendeskgarden/react-components/pull/1872) fix(dropdowns.next): `Combobox` with `isBare` option never shows horiz scrollbar to preserve styling ([@ze-flo](https://github.com/ze-flo))

#### :seedling: Internal
* [#1857](https://github.com/zendeskgarden/react-components/pull/1857) chore(deps-dev): bump express from 4.18.2 to 4.19.2 ([@dependabot[bot]](https://github.com/apps/dependabot))
* [#1863](https://github.com/zendeskgarden/react-components/pull/1863) ci: let known `[bots]` deploy to staging ([@ze-flo](https://github.com/ze-flo))
* [#1859](https://github.com/zendeskgarden/react-components/pull/1859) chore(deps): update dependency eslint-plugin-notice to v1 ([@renovate[bot]](https://github.com/apps/renovate))
* [#1856](https://github.com/zendeskgarden/react-components/pull/1856) ci: fix missing staging deploy status by associating deploy ref to correct SHA ([@ze-flo](https://github.com/ze-flo))
* [#1851](https://github.com/zendeskgarden/react-components/pull/1851) chore: remove CircleCI configuration ([@jzempel](https://github.com/jzempel))

## v8.76.4 (2024-07-01)

#### :seedling: Internal
Expand Down
6 changes: 5 additions & 1 deletion packages/dropdowns/src/elements/combobox/Combobox.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,14 @@ describe('Combobox', () => {
});

it('renders `isBare` styling as expected', () => {
const { getByTestId } = render(<TestCombobox isBare />);
const { getByTestId, rerender } = render(<TestCombobox isBare />);
const combobox = getByTestId('combobox');

expect(combobox.firstChild).toHaveStyleRule('border', 'none');
expect(combobox.firstChild).toHaveStyleRule('overflow-y', 'visible');

rerender(<TestCombobox isBare isMultiselectable />);
expect(combobox.firstChild).toHaveStyleRule('overflow-y', 'auto');
});

it('renders `isCompact` styling as expected', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/dropdowns/src/views/combobox/StyledTrigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const StyledTrigger = styled.div.attrs({
'data-garden-id': COMPONENT_ID,
'data-garden-version': PACKAGE_VERSION
})<IStyledTriggerProps>`
overflow-y: auto;
overflow-y: ${props => (props.isBare && !props.isMultiselectable ? 'visible' : 'auto')};
/* prettier-ignore */
transition:
border-color 0.25s ease-in-out,
Expand Down