fix(dropdowns.next): Combobox with isBare option never shows horiz scrollbar to preserve styling
#1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bar regardless of OS settings
jzempel
requested changes
Jul 25, 2024
| 'data-garden-version': PACKAGE_VERSION | ||
| })<IStyledTriggerProps>` | ||
| overflow-y: auto; | ||
| overflow-y: ${props => (props.isBare ? 'visible' : 'auto')}; |
There was a problem hiding this comment.
Unfortunately, this is problematic for isMultiselectable
There was a problem hiding this comment.
97ac681 maintains the overflow-y: auto when isMultiSelectable == true
4 tasks
geotrev
approved these changes
Aug 1, 2024
geotrev
pushed a commit
that referenced
this pull request
Aug 1, 2024
…z scrollbar to preserve styling (#1872)
geotrev
added a commit
that referenced
this pull request
Aug 1, 2024
* fix(dropdowns.next): `Combobox` with `isBare` option never shows horiz scrollbar to preserve styling (#1872) * chore(changelog): add v8.76.5 [skip ci] --------- Co-authored-by: Florent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The styling of
<Combobox isBare>would break for users with OS settings set to always show scrollbars.This update fixes it by setting the
overflow-yof the input wrapper tovisiblewhenisBareis enabled. After fix:isBareisBareandisMultiSelectableChecklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start)⬅️ renders as expected with reversed (RTL) direction🤘 renders as expected with Bedrock CSS (?bedrock)♿ tested for WCAG 2.1 AA accessibility compliance