Skip to content

Conversation

geotrev
Copy link
Contributor

@geotrev geotrev commented Jul 23, 2024

Description

Provides a light/dark variable set for shadow sizes small, medium, and large. Updates relevant components that currently define custom neutralHue colors with dark/light transparency overrides in v9 styles:

  • Chrome – SkipNav and Header
  • Draggable
  • RangeInput
  • PaneSplitterButton (container)
  • Modals – Modal and Drawer
  • Notification
  • Theming – menuStyles
  • Tooltip (including when isLight is given)

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Contributor

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! 💯

@steue
Copy link

steue commented Jul 24, 2024

LGTM!

@geotrev geotrev merged commit aaaaf1b into next Jul 24, 2024
@geotrev geotrev deleted the george/shadow-vars branch July 24, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants