feat(dropdowns.legacy): new light/dark mode colors #1867
Merged
+48
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT REVIEWER NOTE: due to the fact that this is a deprecated package, I took a path of minimal code disruption. Meaning 1:1
getColorV8
->getColor
replacements and:$prop
updates (we can decide if this needs to happen after v9 releases)colorStyles
&sizeStyles
consolidationCombobox
&Menu
Checklist
npm start
)?bedrock
)includes new unit tests. Maintain existing coverage (always >= 96%)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge