Skip to content

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Jul 19, 2024

Description

IMPORTANT REVIEWER NOTE: due to the fact that this is a deprecated package, I took a path of minimal code disruption. Meaning 1:1 getColorV8 -> getColor replacements and:

  • no $prop updates (we can decide if this needs to happen after v9 releases)
  • no colorStyles & sizeStyles consolidation
  • no style enhancements (such as the primary blue border for active options / focused items) to emphasize the importance of a a11y upgrade to Garden's new Combobox & Menu

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal conversion feels right. Same for a risk assessment for transient props after v9 launches.

Copy link
Contributor

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L👀KING GOOD! 💯

@steue
Copy link

steue commented Jul 24, 2024

LGTM!

@jzempel jzempel merged commit 9dab83f into next Jul 25, 2024
@jzempel jzempel deleted the jzempel/recolor-dropdowns.legacy branch July 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants