chore(deps): update dependency eslint to v9 #1825

renovate · 2024-06-03T06:45:36Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
eslint (source)	`8.57.0` -> `9.7.0`

Release Notes

eslint/eslint (eslint)

`v9.7.0`

Compare Source

Features

7bd9839 feat: add support for es2025 duplicate named capturing groups (#18630) (Yosuke Ota)
1381394 feat: add regex option in no-restricted-imports (#18622) (Nitin Kumar)

Bug Fixes

14e9f81 fix: destructuring in catch clause in no-unused-vars (#18636) (Francesco Trotta)

Documentation

9f416db docs: Add Powered by Algolia label to the search. (#18633) (Amaresh S M)
c8d26cb docs: Open JS Foundation -> OpenJS Foundation (#18649) (Milos Djermanovic)
6e79ac7 docs: loadESLint does not support option cwd (#18641) (Francesco Trotta)

Chores

793b718 chore: upgrade @eslint/js @9.7.0 (#18680) (Francesco Trotta)
7ed6f9a chore: package.json update for @eslint/js release (Jenkins)
7bcda76 refactor: Add type references (#18652) (Nicholas C. Zakas)
51bf57c chore: add tech sponsors through actions (#18624) (Strek)
6320732 refactor: don't use parent property in NodeEventGenerator (#18653) (Milos Djermanovic)
9e6d640 refactor: move "Parsing error" prefix adding to Linter (#18650) (Milos Djermanovic)

Configuration

📅 Schedule: Branch creation - "on Monday every 9 weeks of the year starting on the 5th week" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

geotrev · 2024-07-17T17:56:27Z

Waiting for update to CI to allow bot builds.

ze-flo · 2024-07-17T18:11:17Z

Waiting for update to CI to allow bot builds.

The linting test is failing but there's no indication it's related to the CI config. Is it passing locally?

jzempel · 2024-07-18T14:17:11Z

Waiting for update to CI to allow bot builds.

The linting test is failing but there's no indication it's related to the CI config. Is it passing locally?

This repo hasn't yet been configured for eslint v9 😉

geotrev · 2024-07-24T14:52:06Z

Waiting for update to CI to allow bot builds.

The linting test is failing but there's no indication it's related to the CI config. Is it passing locally?

yes, this is true, good point. haha also the lack of eslint v9 config. 🤦🏻

renovate · 2024-07-26T22:36:13Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

geotrev · 2024-07-30T19:16:36Z

Status of the update:

Still encountering issues with test files. Jest globals don't seem to be recognized like they should (see react-containers where an identical jestPlugin implementation works as expected). Attempting to re-apply jestPlugin.plugins doesn't seem to have any effect here.
garden-local works but the linter runs five times slower. When attempting to run with typescriptPlugin spread to the config entry, typescript complains about @typescript-eslint/adjacent-overload-signatures. Instead, I tried to spread in typescriptPlugin.plugins which ends up stalling eslint indefinitely.

Using eslint's handy-dandy inspector, I can see rules are being applied, but clearly the actual linting process is still kinda jank. 💀

jzempel · 2024-08-21T20:41:19Z

Jest globals don't seem to be recognized like they should

@geotrev ha, those typography lists test files still had .spec.js extensions rather than .spec.tsx

ze-flo · 2024-08-21T21:45:53Z

package.json

-    "@typescript-eslint/parser": "7.18.0",
    "@zendeskgarden/css-bedrock": "9.1.1",
-    "@zendeskgarden/eslint-config": "40.0.0",
+    "@zendeskgarden/eslint-config": "42.0.0",


Should we bump this to the latest v43.0.0 instead?

ze-flo · 2024-08-21T21:46:30Z

packages/datepickers/src/elements/DatePicker/components/Calendar.tsx


      return (
-        <StyledCalendarItem key={`day-${itemsIndex}`} $isCompact={isCompact}>
+        <StyledCalendarItem key={date.toISOString()} $isCompact={isCompact}>


ze-flo

Great work!

renovate bot requested a review from a team as a code owner June 3, 2024 06:45

renovate bot added the PR: Internal 🌱 label Jun 3, 2024

renovate bot force-pushed the renovate/major-eslint-monorepo branch 9 times, most recently from ddbcff8 to 84e999e Compare June 6, 2024 16:52

renovate bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from 0739b59 to d5f2cca Compare June 18, 2024 19:40

renovate bot force-pushed the renovate/major-eslint-monorepo branch 3 times, most recently from a8d6234 to f345f52 Compare July 1, 2024 19:31

renovate bot force-pushed the renovate/major-eslint-monorepo branch 4 times, most recently from 3ead230 to 9fbd22c Compare July 16, 2024 17:50

renovate bot force-pushed the renovate/major-eslint-monorepo branch from 9fbd22c to 8629c38 Compare July 18, 2024 15:49

github-actions bot deployed to staging July 18, 2024 15:57 View deployment

ze-flo mentioned this pull request Jul 18, 2024

chore(deps-dev): bump express from 4.18.2 to 4.19.2 #1857

Merged

chore(deps): update dependency eslint to v9

b11a458

renovate bot force-pushed the renovate/major-eslint-monorepo branch from 8629c38 to b11a458 Compare July 23, 2024 12:30

github-actions bot deployed to staging July 23, 2024 12:39 View deployment

chore: adds eslint v9 config

38363c6

github-actions bot deployed to staging July 26, 2024 22:44 View deployment

chore: fixes ignore paths

bee823e

github-actions bot deployed to staging July 30, 2024 19:06 View deployment

jzempel added 2 commits August 21, 2024 13:51

Merge branch 'main' into renovate/major-eslint-monorepo

6d8f08b

Fix eslint config and linting errors

1aac82d

jzempel added 2 commits August 21, 2024 17:16

Fix react/jsx-no-leaked-render lint errors

9f49a53

Fix package lock

f3b206a

github-actions bot deployed to staging August 21, 2024 21:40 View deployment

ze-flo reviewed Aug 21, 2024

View reviewed changes

Upgrade to eslint-config v43

de23993

ze-flo approved these changes Aug 21, 2024

View reviewed changes

github-actions bot deployed to staging August 21, 2024 22:34 View deployment

jzempel merged commit e009570 into main Aug 22, 2024

jzempel deleted the renovate/major-eslint-monorepo branch August 22, 2024 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): update dependency eslint to v9 #1825

chore(deps): update dependency eslint to v9 #1825

Uh oh!

renovate bot commented Jun 3, 2024 •

edited

Loading

Uh oh!

geotrev commented Jul 17, 2024

Uh oh!

ze-flo commented Jul 17, 2024

Uh oh!

jzempel commented Jul 18, 2024

Uh oh!

geotrev commented Jul 24, 2024

Uh oh!

renovate bot commented Jul 26, 2024

Uh oh!

geotrev commented Jul 30, 2024 •

edited

Loading

Uh oh!

jzempel commented Aug 21, 2024

Uh oh!

ze-flo Aug 21, 2024

Uh oh!

ze-flo Aug 21, 2024

Uh oh!

ze-flo left a comment

Uh oh!

Uh oh!

chore(deps): update dependency eslint to v9 #1825

chore(deps): update dependency eslint to v9 #1825

Uh oh!

Conversation

renovate bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

Features

Bug Fixes

Documentation

Chores

Configuration

Uh oh!

geotrev commented Jul 17, 2024

Uh oh!

ze-flo commented Jul 17, 2024

Uh oh!

jzempel commented Jul 18, 2024

Uh oh!

geotrev commented Jul 24, 2024

Uh oh!

renovate bot commented Jul 26, 2024

Edited/Blocked Notification

Uh oh!

geotrev commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jzempel commented Aug 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-flo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

renovate bot commented Jun 3, 2024 •

edited

Loading

geotrev commented Jul 30, 2024 •

edited

Loading