feat(theming): add arrow/menu position and floating placement utilities #1704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotrev
approved these changes
Feb 8, 2024
jzempel
added a commit
that referenced
this pull request
Feb 8, 2024
…es (#1704) - getFloatingPlacements() - getMenuPosition() - getArrowPosition()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following as a prerequisite for converting Garden to use
floating-uifor positioned components (i.e.Menu,TooltipModal, etc):Detail
Main focus for review should be the function signatures, with special attention to the parameters and return values.
Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)demo is up-to-date (npm start)renders as expected with Bedrock CSS (?bedrock)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge