[APPS-7700] Add validation for scopes attribute for secure param

[aishkan]

💐

/cc @zendesk/wattle

Description

Add validation for scopes attribute for secure param.
Validations added are as follows

• scopes can be nil
• scopes can't be empty []
• scopes can only be present when secure true is set on the attribute
• The validation of scope is based on validate_scopes_for_secure_parameter passed in param

References

https://zendesk.atlassian.net/browse/APPS-7700

Risks

• [RUNTIME] Can this change affect apps rendering for a user? No
• [ low] Can break app validations

[Copilot]

Pull Request Overview

This PR adds validation for the scopes attribute on secure parameters in app manifests. The validation ensures scopes are only used with secure parameters, cannot be empty arrays, and contain only valid scope values from a predefined list.

Key Changes:

• Added validate_scopes_for_secure_parameter flag to control scope validation
• Implemented three validation rules: scopes require secure=true, scopes cannot be empty, and scopes must be from allowed values
• Added comprehensive test coverage for all validation scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
lib/zendesk_apps_support/validations/manifest.rb	Implements scope validation logic with three new error checks and adds SECURE_PARAM_SCOPES constant
lib/zendesk_apps_support/manifest/parameter.rb	Adds scopes to parameter attributes to support reading scope configuration
spec/validations/manifest_spec.rb	Adds comprehensive test coverage for scope validation scenarios including edge cases
config/locales/translations/zendesk_apps_support.yml	Adds translation keys for three new validation error messages
config/locales/en.yml	Adds English text for the three new validation error messages

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mmassaki]

I think the notation without . is closer to the array notation for JSON objects. Adding " as well to indicate it's a value might help.

This is kind of a hybrid between a JSON path and XPATH notation 😄. What do you reckon?

Suggested change

	field: "parameters.[name=#{parameter.name}]",
	field: "parameters[name=\"#{parameter.name}\"]",

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

spec/validations/manifest_spec.rb:10

• Corrected spelling of 'default ocale' to 'default locale'.

      'defaultLocale' => 'default ocale',

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.