-
-
Notifications
You must be signed in to change notification settings - Fork 366
Restore Flake8 configuration #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Saransh-cpp, could you please review? 🙂 |
|
Humorous (?) sidenote: https://pypi.org/project/Flake8-pyproject/ |
|
Yeah saw that. For now think it is ok to keep this in a separate config file. |
Saransh-cpp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jakirkham!
flake8's config is currently stored in pre-commit-config.yaml, and the contributing docs don't instruct developers to use flake8 outside of pre-commit. There shouldn't be any issues with having it in 2 places though (similar to the codespell configuration)! 🚀
|
Ah ok. Thanks Saransh! 🙏 Will |
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 35 35
Lines 14126 14127 +1
=======================================
+ Hits 14125 14126 +1
Misses 1 1
|
Unfortunately, no and no 🥲
|
|
Maybe let's minimally document those lines that require synchronization (and we'll keep looking for unified solutions moving forward)? |
|
Gotcha thanks for looking into this Saransh! 🙏 Yeah would suggest raising a new community issue about using Let's go ahead and merge this change for |
This was accidentally dropped when removing
tox( #1219 ). Here we add a.flake8configuration file with those options. Note it is not currently possible to usepyproject.tomlfor Flake8 ( PyCQA/flake8#234 ).TODO: