Skip to content

Draft: Fixes #131 - adding PGP in secure email doc #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2023
Merged

Draft: Fixes #131 - adding PGP in secure email doc #132

merged 2 commits into from
Jul 26, 2023

Conversation

@ralf401
Copy link
Contributor

@ralf401 ralf401 commented Jul 25, 2023

  • Cleaned also the line length and added some linebreaks
  • Edited the existing document and added PGP

@ralf401 ralf401 requested a review from dvuckovic July 25, 2023 12:03
@ralf401 ralf401 self-assigned this Jul 25, 2023
dvuckovic
dvuckovic requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@dvuckovic dvuckovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralf401 Good work! A couple of changes are suggested, let me know if you need help (especially with reproducing a broken state so you can get the icons).

@ralf401 ralf401 requested a review from dvuckovic July 25, 2023 14:21
dvuckovic
dvuckovic approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@dvuckovic dvuckovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralf401 Great job! Let's keep the Draft: ... in the title for now and embargo the merge until it's go time. Thanks!

@dvuckovic dvuckovic linked an issue Jul 25, 2023 that may be closed by this pull request
PGP: Improve the Secure Email section to cover the PGP integration #131
Closed
@ralf401 ralf401 merged commit b2c7781 into pre-release Jul 26, 2023
@ralf401 ralf401 deleted the rsc/131/secure-email-including-pgp branch July 26, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvuckovic dvuckovic dvuckovic approved these changes

Assignees

@ralf401 ralf401

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PGP: Improve the Secure Email section to cover the PGP integration

2 participants

@ralf401 @dvuckovic