Skip to content

fix path with whitespace and fix "spawn" in vscode #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix path with whitespace and fix "spawn" in vscode #57

wants to merge 2 commits into from

Conversation

@z-juln
Copy link

@z-juln z-juln commented May 16, 2023

  1. fix the problem of error when there are spaces in the path
  2. Error 'error error: spawn code enoent' will be thrown in the vscode environment, so 'exec' is used

@z-juln
Copy link
Author

z-juln commented May 16, 2023

急着用，就先发包了，标了来源
https://www.npmjs.com/package/@juln/launch-editor

@btea
Copy link

btea commented Sep 1, 2024

https://github.com/vuejs/devtools-next depends on this package, and currently, there will be an error when opening the file in vscode. This PR seems to solve this problem, can you reproduce it? @sodatea

haoqunjiang added a commit to haoqunjiang/launch-editor that referenced this pull request Sep 4, 2024
@haoqunjiang
fix: use escape instead of allow list when launching through Windows cmd
cba2c63 
Fixes yyx990803#35
Fixes yyx990803#76
Closes yyx990803#54
Closes yyx990803#57
Fixes yyx990803#74#issuecomment-2269583713
haoqunjiang added a commit to haoqunjiang/launch-editor that referenced this pull request Sep 4, 2024
@haoqunjiang
fix: use escape instead of allow list when launching through Windows cmd
6cd0b12 
Fixes yyx990803#35
Fixes yyx990803#76
Closes yyx990803#54
Closes yyx990803#57
Fixes yyx990803#74#issuecomment-2269583713
@haoqunjiang haoqunjiang mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@z-juln @btea