Drop the connection on context cancellation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

vrok wants to merge 1 commit into yhat:master from vrok:master

vrok commented Aug 16, 2017

This should be safe:

r.Context() is always non-nil
r.Context().Done() can be nil, but reading from nil channels just blocks forever


          Drop the connection on context cancellation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet