Move js-framework-benchmark to yew monorepo #2302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bakape Maybe you have any clue about those paint events? |
|
@hamza1311 was not too keen on moving benchmarks to yew monorepo so I'm closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves https://github.com/yewstack/js-framework-benchmark to our main yew repository.
Probably I did not do this properly as all git history got lost.
Should i do this in a different way or this is fine? (My reasoning was that this is fine as this is just a tool and licences dont seem to disallow doing this)
Checklist
cargo make pr-flow