Add Cow helpers for IString #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful in cases like passing the IString to a function which takes a Cow without needing to clone the content
|
The Clippy failure is unrelated. It's likely that the derived implementation of PartialEq that clippy is highlighting is wrong |
cecton
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
I'm just seeing this now but it's nice! You should have ping me.
You can disable the lint for the impl of Eq at crate level I think it's not relevant here. We don't want to enforce the user to implement Eq on all their types otherwise they won't be able to store f32 and f64 in an IArray
| assert_eq!(Rc::strong_count(&rc_s), 2); | ||
| // this assert exists to ensure the cow lives after the strong_count asset | ||
| assert_eq!(cow, "foo"); | ||
|
|
Comment on lines
+84
to
+91
| impl From<Cow<'static, str>> for IString { | ||
| fn from(cow: Cow<'static, str>) -> Self { | ||
| match cow { | ||
| Cow::Borrowed(s) => IString::Static(s), | ||
| Cow::Owned(s) => s.into(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think you forgot to write a test for this. It's not super important but it makes sure that someone does not remove it by mistake
|
I'm going to merge this. The test can be added later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
IString::as_cowimpl From<Cow<'static, str>> for IString