Skip to content

Improves performances #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Improves performances #42

merged 2 commits into from
Jul 10, 2025

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Jul 10, 2025

  • The original code was computing the join call even when the path didn't use either __virtual__ or .zip.
  • Vectors were allocated empty. I updated that to preallocate a small arbitrary amount of items.

@github-actions GitHub Actions
Copy link
Contributor

Benchmark for ccf4c8b

Click to view benchmark
Test Base PR %
vpath_edge_cases 3.0±0.10µs 2.5±0.08µs -16.67%
vpath_mixed_workload 5.1±0.17µs 4.5±0.16µs -11.76%
vpath_native 1909.5±62.57ns 1492.9±59.53ns -21.82%
vpath_virtual 3.5±0.13µs 3.4±0.08µs -2.86%
vpath_virtual_zip 2.9±0.12µs 2.8±0.08µs -3.45%
vpath_zip 2.0±0.07µs 1916.7±61.78ns -4.16%

@arcanis arcanis merged commit 5bbfa6b into main Jul 10, 2025
6 checks passed
@arcanis arcanis deleted the mael/perfs branch July 10, 2025 10:52
@github-actions github-actions bot mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arcanis