fix: unknown-options-as-args now respects short-option-groups #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@shadowspawn bother you to rebase this, and we'll get a release out with all your changes 👏 |
shadowspawn
force-pushed
the
fix_unknown-options-as-arg_with_short-option-groups
branch
from
e1951ea to
d0e64e5
Compare
shadowspawn
force-pushed
the
fix_unknown-options-as-arg_with_short-option-groups
branch
from
d0e64e5 to
e8ac0a4
Compare
Member
Author
|
Done. (I will update #509 now too.) |
shadowspawn
deleted the
fix_unknown-options-as-arg_with_short-option-groups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isUnknownOptionwas not checkingshort-option-groupsbefore looking for short option groups. Noticed by code inspection while reviewing past and presentunknown-options-as-argsissues and code.For amusement. Despite what you might expect, not a fix for #312.