Fix scrollbar teleport after exiting alt buffer #5390
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
commented
Aug 28, 2025
src/common/buffer/BufferSet.ts
Outdated
| inactiveBuffer: this._alt | ||
| }); | ||
| // Prevent scrollbar "teleport" to top of the terminal, from previous alt buffer. | ||
| this._bufferService.syncScrollPosition(); |
Contributor
Author
There was a problem hiding this comment.
Gist: Seems like we had the correct ydisp the whole time, but just needed to update/refresh after coming back from alt buffer.
Had to add public method syncScrollPosition() and call it from here since _onScroll was private to bufferService.
Tyriar
requested changes
Aug 28, 2025
Tyriar
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the first issue (teleport issue) from: microsoft/vscode#224750 (comment)