Right-click paste does not work

[parisk]

Right-click paste does not work. This regression was caused after #175, since we moved input handling to a textarea instead of xterm itself.

Proposals

This could be solved in the following two ways (additional ideas are always welcome though)

1. Temporarily move the textarea element below the mouse cursor on right click (Add textarea back and support IMEs #175 (comment)). This would need non-native selection handling though (Add textarea back and support IMEs #175 (comment)).
2. Temporarily give focus and enable contenteditable on the terminal element to allow pasting without messing with text selection issues.

Out of these two proposals IMO 1. is the best way to go (it will also fix other bugs like #116), but it will need definitely more work, while 2. is a quick hack that could do the job for now.

Details

• Browser and browser version: All browsers
• OS version: All OSes
• xterm.js version: >= 10fbf0d

Steps to reproduce

1. Right click on the terminal
2. Notice that there is no Paste option in the right click menu, while it should

[Tyriar]

This could be fixed by the solution suggested in #273, and maybe resizing the textarea on mousedown or redirecting the event to that element?

[parisk]

Wouldn't this break the copy event then, since there will be no selection?

[Tyriar]

Yeah needs to be thought through a bit, I know it would work with electron but copying is a bit more restrictive without node apis.