Recognize supplementary characters #913
Conversation
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public static bool IsWhitespace(this Rune r) => r.IsBmp && IsWhitespace((char)r.Value); |
There was a problem hiding this comment.
Please make these new helpers internal.
No two specs agree on what space means, so I'd avoid exposing more ambiguous extensions on common types (it's not obvious this is CommonMark-specific).
(same for all new helpers in this file)
| } | ||
|
|
||
| #if !(NETSTANDARD2_1_OR_GREATER || NETCOREAPP2_1_OR_GREATER) | ||
| private static Lazy<Func<int, UnicodeCategory>?> GetUnicodeCategoryReflection = |
There was a problem hiding this comment.
I think we should fallback to CharUnicodeInfo.GetUnicodeCategory(value.ToString(), 0) instead.
It's the same thing that .NET itself uses in its Rune impl for Framework.
| if (start < 1) return default; | ||
| var trueFirst = Text[start - 1]; | ||
| if (!char.IsHighSurrogate(trueFirst)) return default; | ||
| return new Rune(trueFirst, first); |
There was a problem hiding this comment.
This seems like a usage error, I would avoid reading backwards in these helpers.
(same for all of these)
| <ItemGroup Condition=" '$(TargetFramework)' == 'net462' OR '$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'netstandard2.1'"> | ||
| <PackageReference Include="Shim.System.Text.Rune" Version="6.0.2" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Please remove the new dependency, we should polyfill the required Rune logic instead
https://github.com/xoofx/markdig/tree/master/src/Markdig/Polyfills
The new Rune helpers on StringSlice can be internal (or at least internal on targets without Rune in the base libraries).
2 participants
Fixes #860