CA-417520: Fix firewalld issues for HA #6688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
requested changes
Sep 29, 2025
BengangY
force-pushed
the
private/bengangy/CA-417520
branch
from
e3052e0 to
686448e
Compare
1. HA supports 2 cluster stacks: xha and corosync. Only xha needs to control firewalld service dynamically. For corosync HA, the firewalld service dlm has been already controlled by the xapi-clusterd, so it doesn't need to control dynamically. 2. Slave's HA is shutdown in `ha_wait_for_shutdown_via_statefile`. Add disabling firewalld service here. Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CA-417520
branch
from
686448e to
f573e26
Compare
psafont
reviewed
Oct 9, 2025
psafont
reviewed
Oct 9, 2025
psafont
approved these changes
Oct 10, 2025
robhoes
approved these changes
Oct 10, 2025
BengangY
merged commit 351f29c
into
xapi-project:feature/dynamic-firewalld-control
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server_init. Checking HA configuration depends on the firewalld service, so move the updating firewalld service before checking HA configuration.ha_wait_for_shutdown_via_statefile. Add disabling firewalld service here.