-
Notifications
You must be signed in to change notification settings - Fork 292
xapi: Add secure boot field to host datamodel #6687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f6c6792
to
51e90fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build needs fixing but approving for once that's done. make build
probably didn't pick up on the error but if you do dune build @check
it will have. You can just use _ instead of e in your try with.
51e90fd
to
524bf04
Compare
Thanks, I'll be sure to run those checks ahead of time next time. I've been force pushing a couple little issues that I could've caught before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stylistic choices for the docs, but other than that it looks good
; { | ||
param_type= Bool | ||
; param_name= "secure_boot" | ||
; param_doc= "True if the host is in secure boot mode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
; param_doc= "True if the host is in secure boot mode" | |
; param_doc= "Whether the host has booted in secure boot mode" |
a79b4f7
to
32fd7cf
Compare
All changes should be integrated now |
I don't think so :) |
28de08d
to
aa109d0
Compare
The secure boot status can be read from the fifth byte of file /sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c This adds a secure_boot field to the host datamodel, which is set during dbsync to the value held in the above file. Signed-off-by: Christian Pardillo Laursen <[email protected]>
aa109d0
to
06e8b6b
Compare
The secure boot status can be read from the fifth byte of file /sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c
This adds a secure_boot field to the host datamodel, which is set during dbsync to the value held in the above file.