Skip to content

Conversation

cplaursen
Copy link
Contributor

The secure boot status can be read from the fifth byte of file /sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c

This adds a secure_boot field to the host datamodel, which is set during dbsync to the value held in the above file.

@cplaursen cplaursen force-pushed the secure_boot branch 2 times, most recently from f6c6792 to 51e90fd Compare September 26, 2025 10:49
Copy link
Contributor

@snwoods snwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build needs fixing but approving for once that's done. make build probably didn't pick up on the error but if you do dune build @check it will have. You can just use _ instead of e in your try with.

@cplaursen
Copy link
Contributor Author

Thanks, I'll be sure to run those checks ahead of time next time. I've been force pushing a couple little issues that I could've caught before.

Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic choices for the docs, but other than that it looks good

; {
param_type= Bool
; param_name= "secure_boot"
; param_doc= "True if the host is in secure boot mode"
Copy link
Member

@psafont psafont Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
; param_doc= "True if the host is in secure boot mode"
; param_doc= "Whether the host has booted in secure boot mode"

@cplaursen cplaursen force-pushed the secure_boot branch 2 times, most recently from a79b4f7 to 32fd7cf Compare September 26, 2025 13:26
@cplaursen
Copy link
Contributor Author

All changes should be integrated now

@robhoes
Copy link
Member

robhoes commented Sep 26, 2025

All changes should be integrated now

I don't think so :)

@lindig lindig added this pull request to the merge queue Sep 29, 2025
The secure boot status can be read from the fifth byte of file
/sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c

This adds a secure_boot field to the host datamodel, which is set
during dbsync to the value held in the above file.

Signed-off-by: Christian Pardillo Laursen <[email protected]>
@edwintorok edwintorok removed this pull request from the merge queue due to a manual request Sep 29, 2025
@edwintorok edwintorok added this pull request to the merge queue Sep 29, 2025
Merged via the queue into xapi-project:master with commit 75db25c Sep 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants