xenopsd/bootloader: No need to create /var/run/xend/boot anymore
#6686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
I'd like to see this reviewed by @rosslagerwall . The code change in itself is trivial.
|
@rosslagerwall @andyhhp: any objection to this? |
|
This needs a rebase to pick up CI changes. |
Since c009651 ("pygrub: make sure /var/run/xend/boot exists before calling pygrub") added this safety measure, pygrub moved to using /var/run/xen/boot (see 63dcc68151 ("tools/pygrub: store kernels in /var/run/xen/pygrub") in upstream xen https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=63dcc681511356d42645ef2c78955864e3b3e6b9) and started creating the directory itself (if it doesn't already exist). It's time to drop this unnecessary workaround. Signed-off-by: Andrii Sultanov <[email protected]>
last-genius
force-pushed
the
asv/pygrub-fix
branch
from
8995a8b to
c61bb6c
Compare
andyhhp
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
@last-genius One thing that I find helpful when citing commits is to give their year. In this case, the Xen change you cite is from 2014, so more than a decade old.
|
@robhoes This was ok'ed by Andy - so would suggest you tick it and It will go in. |
robhoes
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since c009651
("pygrub: make sure /var/run/xend/boot exists before calling pygrub")added this safety measure, pygrub moved to using/var/run/xen/boot(see 63dcc68151("tools/pygrub: store kernels in /var/run/xen/pygrub")in upstream xen ) and started creating the directory itself (if it doesn't already exist).It's time to drop this unnecessary workaround.