XSI-1969 more thorough resource cleanup #6682
Conversation
In XSI-1969 we deal with an inconsistent Xapi DB and fail to recognise a PCI as SRIOV. Be more lenient and recognise stale PCI refs as SRIOV. Also remove a VM from a VGPU explictly on resouce cleanup. Signed-off-by: Christian Lindig <[email protected]>
|
This is really curious and I would love it if you could provide some more context. Surely returning a reference to an object that is somehow invalid (ref = null, missing table) can't do any good further on. What do you mean by an "inconsistent" db? |
|
A PCI that belongs to an SRIOV vGPU does not block migration, but a pass-through PCI does. We have cases where this is happening: a stale/inbvalid PCI from an SRIOV blocks migration. Why the PCI data is stale is not clear but the PCI clearly belongs to an SRIOV vGPU but is now considered pass-throgh. So I am removing the validity check to let the migration proceed. Once migrated, we would assign new PCI devices. So I believe this improves the situation slightly and does not make it worse. |
|
@GabrielBuica please merge this when you feel it is save |
In XSI-1969 we deal with an inconsistent Xapi DB and fail to recognise a PCI as SRIOV. Be more lenient and recognise stale PCI refs as SRIOV. Also remove a VM from a VGPU explictly on resouce cleanup.