ocaml: prepare formatting for ocamlformat 0.27.0 #6678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBuica
approved these changes
Sep 19, 2025
|
I'd rather not merge this PR as it is, I'd rather revert the version of ocamlformat in xs-opam. I'm leaving this open for visibility of the issue until I fix it on Monday |
minglumlu
approved these changes
Sep 22, 2025
|
To fix the builds, this should be merged instead: xapi-project/xs-opam#739 I will remove most of the changes and leave the ones that work for both ocamlformat versions |
This changes comments as well as the location of some comments,otherwise ocamlformat is unable to process files Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
dev/psafont/format
branch
from
0b9c428 to
bdf06bc
Compare
Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
changed the title
Merged
via the queue into
xapi-project:master
with commit Sep 22, 2025
94fcd59
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments have had its location changed because this version of ocamlformat got confused with them.
Ignoring whitespace changes is highly recommended, there's a button with a square as its icon on top of each commit page to do enable this mode.