docs: Update add-function.md to fix example #6673
Conversation
| do_op_on ~local_fn ~__context ~host | ||
| (fun session_id rpc -> Client.Host.price_of ~rpc ~session_id ~host ~item) | ||
| let remote_fn = Client.Host.price_of ~host ~item in | ||
| do_op_on ~local_fn ~__context ~host ~remote_fn |
There was a problem hiding this comment.
Indeed, do_op_on now has a named argument ~remote_fn, which it previously didn't have.
| - The ~flags parameter is used to set conditions for the use of the message. | ||
| For example, `Session is used to indicate that the call must be made in the | ||
| presence of an existing session. | ||
| presence of an existing session`. |
There was a problem hiding this comment.
The backtick here is actually for the OCaml polymorphic variant
`Session
so there shouldn't be one at the end.
|
Welcome. As the failed DCO job log says, use |
|
Looks like the DCO check is not happy if the committer email and sign-off emails are not the same:
|
cplaursen
force-pushed
the
docs-edit
branch
2 times, most recently
from
f0611a5 to
1ff09d1
Compare
|
Thanks for this, I force pushed the change and added the cloud address to my github account, but it still seems unhappy with it. Do I need to make the cloud address my primary one to sign off with it? |
|
I think it is about your local git email config. |
When performing the changes described in add-function.md for adding a host-price-of function to xapi, a type error would arise from the message-forwarding.ml file - this is fixed by explicitly giving the remote_fn named argument. Signed-off-by: Christian Pardillo Laursen <[email protected]>
cplaursen
force-pushed
the
docs-edit
branch
from
1ff09d1 to
0980515
Compare
|
All done! |
4 participants
When performing the changes described in add-function.md for adding a host-price-of function to xapi, a type error would arise from the message-forwarding.ml file - this is fixed by explicitly giving the remote_fn named argument.