CA-416532: Revert #6586, overwrites /etc/resolve.conf #6643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onf (xapi-project#6586)" This reverts commit 05e6317, reversing changes made to 1fbdaae. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/v25.29.0-fix
branch
from
638b883 to
ec61f8e
Compare
|
There was a 2nd commit there, bdbd975, I assume this was fine? |
edwintorok
approved these changes
Sep 1, 2025
GabrielBuica
changed the title
|
Looks like both commits are reverted here. The second one, bdbd975, was the main problem. |
robhoes
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts @psafont's PR, #6586, this causing the
/etc/resolve.confto be overwritten during update, after the dhclient writes it. This happens becauseset_dnsno longer checks the mode before applying the DNS config,This reverts commit 05e6317, reversing changes made to 1fbdaae.