-
Notifications
You must be signed in to change notification settings - Fork 292
CP-308539: Updated certificate validation to support .NET 8.0 in PowerShell. #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<Version>0.0.0</Version> | ||
<TargetFrameworks>net8.0;net6.0;net45</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failed. https://github.com/xapi-project/xen-api/blob/master/.github/workflows/generate-and-build-sdks.yml#L208 together need change if remove net6.0.
…rShell. Signed-off-by: Konstantina Chremmou <[email protected]>
Not sure what is wrong with 'Test SDK builds / Build PowerShell 7.x SDK (6)'. Says pending but isn't running anywhere I can see. Maybe here: https://github.com/xapi-project/xen-api/actions/runs/17372094678 |
I think the tests have succeeded now, but something else got merged to master, which restarted the CI on this PR. |
Ah .NET 6 is removed in this PR, but the CI still expects a response from that for some reason. |
I tried reraising it anew, but I'm having the same problem in #6644 |
I'll check the repo settings, maybe it is defined as a required check. |
It was defined as a required test in the branch protection rules for |
Ok, thank you! |
No description provided.