CP-309523: Make networkd_db utility return bridge MAC address #6637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changlei-li
reviewed
Aug 26, 2025
ocaml/networkd/bin_db/networkd_db.ml
Outdated
| in | ||
| Printf.printf "interfaces=%s\n" (String.concat "," ifaces) ; | ||
| Printf.printf "hwaddrs=%s\n" | ||
| (String.concat "," (Option.to_list bridge_config.bridge_mac)) ; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes. It's enough for host installer but not from the utility's perspective. The utility can be used independently as well.
Another point, can we get the mac addresses in host installer from interface-rename-data at the mount point?
It's possible but it would get the host installer changed too much - mounting the partition in that place. The networkd_db utility seems the best to get the information even in the future.
There was a problem hiding this comment.
Let me have a try on host installer. I think the file can be retrieved at that point.
There was a problem hiding this comment.
The type of bridge_mac is string option, so String.concat "," (Option.to_list ... is a little odd. What about Option.value ~default:""?
changlei-li
approved these changes
Aug 27, 2025
BengangY
approved these changes
Aug 27, 2025
|
This PR needs a rebase on top of the latest master to pass the required tests |
minglumlu
force-pushed
the
private/mingl/CP-309523
branch
from
1ef3968 to
99dbe56
Compare
This is a simplified version of commit 846ce82. The feature introduced that commit is to remove the network device renaming functionality. When the feature is merged, there will be 3 states of releases: 1. without the feature. 2. with the feature but renaming is still working. 3. with the feature and renaming has been removed. Originally, the upgrade path was intended to support transitions from state 2 to state 3 only. However, it has become necessary to also support upgrades directly from state 1 to state 3. This commit is to enable the release in state 1 to upgrade to state 3. The change is kept extremely small so it can be merged independently without waiting for the full feature to be merged. In details, during the upgrade, the host-installer can't know the management interface as the eth<N> will not present in the environment the host-installer running. So it needs the MAC address to find out the management interface for setting up network. Signed-off-by: Ming Lu <[email protected]>
minglumlu
force-pushed
the
private/mingl/CP-309523
branch
from
99dbe56 to
31b8461
Compare
robhoes
approved these changes
Sep 3, 2025
changlei-li
added a commit
to changlei-li/xen-api
that referenced
this pull request
Sep 9, 2025
Conflict between xapi-project#6637 and xapi-project#6466. The PR xapi-project#6637 on master is a simplified version of PR xapi-project#6466 for upgrade from master to feature version. To solve the conflict, keep xapi-project#6466.
changlei-li
added a commit
to changlei-li/xen-api
that referenced
this pull request
Sep 9, 2025
Conflict between xapi-project#6637 and xapi-project#6466. The PR xapi-project#6637 on master is a simplified version of PR xapi-project#6466 for upgrade from master to feature version. To solve the conflict, keep xapi-project#6466, drop xapi-project#6637. Signed-off-by: Changlei Li <[email protected]>
changlei-li
added a commit
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified version of commit 846ce82. The feature introduced that commit is to remove the network device renaming functionality. When the feature is merged, there will be 3 states of releases:
Originally, the upgrade path was intended to support transitions from state 2 to state 3 only. However, it has become necessary to also support upgrades directly from state 1 to state 3.
This commit is to enable the release in state 1 to upgrade to state 3. The change is kept extremely small so it can be merged independently without waiting for the full feature to be merged.
In details, during the upgrade, the host-installer can't know the management interface as the eth will not present in the environment the host-installer running. So it needs the MAC address to find out the management interface for setting up network.