Fix tests that don't work on aarch64 #6630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last-genius
approved these changes
Aug 20, 2025
| notes | ||
|
|
||
| let () = | ||
| Suite_init.harness_init () ; |
There was a problem hiding this comment.
I wonder if we could drop this in any other tests, maybe this would make tests slightly faster
There was a problem hiding this comment.
We don't use the code that reads notes from ELF files anymore and could remove the test.
There was a problem hiding this comment.
I'll drop the test, then
|
Ah, changes are needed to the required checks because now the x86 ones changed its name. When this is ready to merge I'll change the protected branches, otherwise people won't be able to merge to master |
lindig
approved these changes
Aug 21, 2025
| notes | ||
|
|
||
| let () = | ||
| Suite_init.harness_init () ; |
There was a problem hiding this comment.
We don't use the code that reads notes from ELF files anymore and could remove the test.
Unfortunately, the backtrace in aarch64 has one location less than on x86_64, at least on ocaml 4.14.2, so we have to change the test to check for some repetitions instead of just matching the whole output. Signed-off-by: Pau Ruiz Safont <[email protected]>
The tests for the module needed to be modified to be made more robust against failures and make it work under aarch64, but the code is unused, so simply remove all of it. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
dev/psafont/arm64
branch
from
ac6fcab to
ad06c0a
Compare
psafont
force-pushed
the
dev/psafont/arm64
branch
from
ad06c0a to
9203724
Compare
psafont
changed the title
lindig
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an ongoing effort to create an xcp-ng port for ARM servers, to help maintain compatibility in the toolstack, these changes make the tests pass on aarch64 and unblock adding CI testing on xs-opam.
Before enabling the CI in xen-api, some packages need to be removed from xs-opam: xapi-project/xs-opam#737
I will open a PR enabling aarch64 runners on xen-api once the xs-opam tests are passing, on both repositories the new CI is set to experimental to avoid blocking any merges